fix!: statistical functions should return null when provided a vector of only null values
#5606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbooker42
added
DocumentationNeeded
breaking
ReleaseNotesNeeded
rcaudy
reviewed
Jun 14, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/by/CharChunkedVarOperator.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/FloatChunkedVarOperator.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/FloatChunkedVarOperator.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/FloatChunkedVarOperator.java
Show resolved
Hide resolved
| return 0.5 * (copy[n / 2 - 1] + copy[n / 2]); | ||
| else return copy[n / 2]; | ||
| // NULL values sorted to beginning of the array. | ||
| ${pt.primitive}[] copy = sort(values.toArray()); |
There was a problem hiding this comment.
This is not ideal. The implementation of sort is sub-optimal:
- We make one
toArray()call internally. - Then we make an array of boxed values.
- Then we sort using a comparator.
- Then we make a third copy wherein we unbox the values.
Sorting on the vector at least let's us skip one of the copies.
We should write a separate ticket for updating the sort kernels in io.deephaven.engine.table.impl.sort to have a version that does not bother with a valuesToPermute chunk, and use that version for the implementation of sort. This way we make exactly one copyToArray() and we're done. Note copyToArray(), not toArray(): we mustn't sort our backing array.
lbooker42
commented
Jun 17, 2024
chipkent
reviewed
Jun 17, 2024
chipkent
reviewed
Jun 17, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/by/ByteChunkedVarOperator.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/DoubleChunkedVarOperator.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/IntChunkedVarOperator.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/LongChunkedVarOperator.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/ShortChunkedVarOperator.java
Outdated
Show resolved
Hide resolved
chipkent
reviewed
Jun 17, 2024
rcaudy
reviewed
Jun 17, 2024
lbooker42
commented
Jun 18, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/by/FloatChunkedVarOperator.java
Show resolved
Hide resolved
rcaudy
reviewed
Jun 18, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/by/CharChunkedVarOperator.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/FloatChunkedVarOperator.java
Outdated
Show resolved
Hide resolved
chipkent
reviewed
Jun 18, 2024
chipkent
reviewed
Jun 18, 2024
rcaudy
previously approved these changes
Jun 18, 2024
Accepting PR suggestions Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
Accepting PR suggestions Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
rcaudy
approved these changes
Jun 18, 2024
|
Labels indicate documentation is required. Issues for documentation have been opened: Community: deephaven/deephaven-docs-community#239 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Numeric functions and tests:
nullvalues presentnullvalues presentUpdated UpdateBy aggregations and tests:
Updated AggBy aggregations:
Will close #5564